https://git.savannah.gnu.org/cgit/coreutils.git/patch/?id=e8b56ebd536e82b15542a00c888109471936bfda https://lists.gnu.org/archive/html/bug-coreutils/2021-09/msg00031.html (and https://lists.gnu.org/archive/html/bug-coreutils/2021-09/msg00035.html) From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Fri, 24 Sep 2021 20:57:41 +0100 Subject: chmod: fix exit status when ignoring symlinks * src/chmod.c: Reorder enum so CH_NOT_APPLIED can be treated as a non error. * tests/chmod/ignore-symlink.sh: A new test. * tests/local.mk: Reference the new test. * NEWS: Mention the bug fix. Fixes https://bugs.gnu.org/50784 --- a/src/chmod.c +++ b/src/chmod.c @@ -44,8 +44,8 @@ struct change_status enum { CH_NO_STAT, - CH_NOT_APPLIED, CH_FAILED, + CH_NOT_APPLIED, CH_NO_CHANGE_REQUESTED, CH_SUCCEEDED } @@ -322,7 +322,7 @@ process_file (FTS *fts, FTSENT *ent) if ( ! recurse) fts_set (fts, ent, FTS_SKIP); - return CH_NO_CHANGE_REQUESTED <= ch.status; + return CH_NOT_APPLIED <= ch.status; } /* Recursively change the modes of the specified FILES (the last entry