From 96423b52302a01fa3a4922961bd8e072a5c46e15 Mon Sep 17 00:00:00 2001 From: V3n3RiX Date: Fri, 16 Sep 2022 01:06:50 +0100 Subject: bugfix : * subprocess.Popen child processes can "sometimes" generate a very large output, causing a deadlock (**cough** dependency solver **cough**) * use subprocess.Popen.communicate instead of subprocess.Popen.wait to avoid such issues * see : https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait --- src/backend/forceuninstall.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/backend/forceuninstall.py') diff --git a/src/backend/forceuninstall.py b/src/backend/forceuninstall.py index b027004..9329695 100644 --- a/src/backend/forceuninstall.py +++ b/src/backend/forceuninstall.py @@ -7,8 +7,8 @@ import sisyphus.database def start(pkgname): if sisyphus.check.root(): - portageExec = subprocess.Popen(['emerge', '--quiet', '--unmerge', '--ask'] + list(pkgname)) - portageExec.wait() + portageExec = subprocess.Popen(['emerge', '--quiet', '--unmerge', '--ask'] + list(pkgname), stdout=subprocess.PIPE, stderr=subprocess.PIPE) + stdout, stderr = portageExec.communicate() sisyphus.database.syncLocal() else: sys.exit("\nYou need root permissions to do this, exiting!\n") -- cgit v1.2.3