diff options
author | V3n3RiX <venerix@koprulu.sector> | 2022-03-20 00:40:44 +0000 |
---|---|---|
committer | V3n3RiX <venerix@koprulu.sector> | 2022-03-20 00:40:44 +0000 |
commit | 4cbcc855382a06088e2f016f62cafdbcb7e40665 (patch) | |
tree | 356496503d52354aa6d9f2d36126302fed5f3a73 /kde-frameworks/knewstuff/files | |
parent | fcc5224904648a8e6eb528d7603154160a20022f (diff) |
gentoo resync : 20.03.2022
Diffstat (limited to 'kde-frameworks/knewstuff/files')
-rw-r--r-- | kde-frameworks/knewstuff/files/knewstuff-5.90.0-add-conditional-cache-preference.patch | 61 | ||||
-rw-r--r-- | kde-frameworks/knewstuff/files/knewstuff-5.90.0-ensure-correct-ProvidersUrl.patch | 27 |
2 files changed, 88 insertions, 0 deletions
diff --git a/kde-frameworks/knewstuff/files/knewstuff-5.90.0-add-conditional-cache-preference.patch b/kde-frameworks/knewstuff/files/knewstuff-5.90.0-add-conditional-cache-preference.patch new file mode 100644 index 000000000000..80a8451ec990 --- /dev/null +++ b/kde-frameworks/knewstuff/files/knewstuff-5.90.0-add-conditional-cache-preference.patch @@ -0,0 +1,61 @@ +From e1c6f2bf383876a31cd3e3f9e6edcaa19dc0a7dd Mon Sep 17 00:00:00 2001 +From: Dan Leinir Turthra Jensen <admin@leinir.dk> +Date: Wed, 9 Feb 2022 16:17:58 +0000 +Subject: [PATCH] Add conditional cache preference to http requests + +If we have a cache that's older than 7 days, assume that it's out of +date and actually try again. If it's younger than that, assume that it's +just the same, and prefer our cached version, if we have one. + +The logic here is an attempt at striking a balance between using our cache +to its fullest potential (as in, reducing server-side load and network +roundtrips in general) while also handling the situation where the +information that we are fed about the cache is not entirely correct (such +as the case where we're told there's no expiration date, but the data in +fact does change). 7 days seems a sensible sort of deadline for that, +though we could change that later if we need to. + +This was born out of a discussion on another kns review[1] + +Assume that no cache expiration time will be longer than 7 days, but otherwise prefer the cache +This is mildly hacky, but if we don't do this, we end up with infinite cache expirations in some +cases, which of course isn't really acceptable... See ed62ee20 for a situation where that happened. + +[1] https://invent.kde.org/frameworks/knewstuff/-/merge_requests/166#note_394067 +--- + src/core/jobs/httpworker.cpp | 12 +++++++++++- + 1 file changed, 11 insertions(+), 1 deletion(-) + +diff --git a/src/core/jobs/httpworker.cpp b/src/core/jobs/httpworker.cpp +index b52161f6..208e1ef0 100644 +--- a/src/core/jobs/httpworker.cpp ++++ b/src/core/jobs/httpworker.cpp +@@ -41,7 +41,6 @@ public: + return nam.get(request); + } + +-private: + QNetworkDiskCache cache; + }; + +@@ -101,6 +100,17 @@ static void addUserAgent(QNetworkRequest &request) + agentHeader += QStringLiteral("-%1/%2").arg(QCoreApplication::instance()->applicationName(), QCoreApplication::instance()->applicationVersion()); + } + request.setHeader(QNetworkRequest::UserAgentHeader, agentHeader); ++ ++ // Assume that no cache expiration time will be longer than a week, but otherwise prefer the cache ++ // This is mildly hacky, but if we don't do this, we end up with infinite cache expirations in some ++ // cases, which of course isn't really acceptable... See ed62ee20 for a situation where that happened. ++ QNetworkCacheMetaData cacheMeta{s_httpWorkerNAM->cache.metaData(request.url())}; ++ if (cacheMeta.isValid()) { ++ const QDateTime nextWeek{QDateTime::currentDateTime().addDays(7)}; ++ if (cacheMeta.expirationDate().isValid() && cacheMeta.expirationDate() < nextWeek) { ++ request.setAttribute(QNetworkRequest::CacheLoadControlAttribute, QNetworkRequest::PreferCache); ++ } ++ } + } + + void HTTPWorker::startRequest() +-- +GitLab + diff --git a/kde-frameworks/knewstuff/files/knewstuff-5.90.0-ensure-correct-ProvidersUrl.patch b/kde-frameworks/knewstuff/files/knewstuff-5.90.0-ensure-correct-ProvidersUrl.patch new file mode 100644 index 000000000000..130ca3dfbd5d --- /dev/null +++ b/kde-frameworks/knewstuff/files/knewstuff-5.90.0-ensure-correct-ProvidersUrl.patch @@ -0,0 +1,27 @@ +From c8165b7a0d622e318b3353ccf257a8f229dd12c9 Mon Sep 17 00:00:00 2001 +From: Aleix Pol <aleixpol@kde.org> +Date: Tue, 8 Feb 2022 11:48:11 +0100 +Subject: [PATCH] Engine: Ensure we are not using the wrong ProvidersUrl + +--- + src/core/engine.cpp | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/src/core/engine.cpp b/src/core/engine.cpp +index 139dda1a..c96ba890 100644 +--- a/src/core/engine.cpp ++++ b/src/core/engine.cpp +@@ -264,6 +264,10 @@ bool Engine::init(const QString &configfile) + Q_EMIT uploadEnabledChanged(); + + m_providerFileUrl = group.readEntry("ProvidersUrl"); ++ if (m_providerFileUrl == QLatin1String("https://download.kde.org/ocs/providers.xml")) { ++ m_providerFileUrl = QStringLiteral("https://autoconfig.kde.org/ocs/providers.xml"); ++ qCWarning(KNEWSTUFFCORE) << "Please make sure" << configfile << "has ProvidersUrl=https://autoconfig.kde.org/ocs/providers.xml"; ++ } + if (group.readEntry("UseLocalProvidersFile", "false").toLower() == QLatin1String{"true"}) { + // The local providers file is called "appname.providers", to match "appname.knsrc" + m_providerFileUrl = QUrl::fromLocalFile(QLatin1String("%1.providers").arg(configFullPath.left(configFullPath.length() - 6))).toString(); +-- +GitLab + |