1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
|
From 8e589adb92a7d5c8c9e8d35bb116ad5ab0686e30 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?=
<shyouhei@ruby-lang.org>
Date: Tue, 26 Nov 2024 13:42:54 +0900
Subject: [PATCH] stop worrying and just pass bare function
`rb_define_method` etc. already take care arities. You don't have
to apply RUBY_METHOD_FUNC.
---
ext/brotli/brotli.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ext/brotli/brotli.c b/ext/brotli/brotli.c
index cb69500..a9cc23d 100644
--- a/ext/brotli/brotli.c
+++ b/ext/brotli/brotli.c
@@ -475,9 +475,9 @@ Init_brotli(void)
rb_mBrotli = rb_define_module("Brotli");
rb_eBrotli = rb_define_class_under(rb_mBrotli, "Error", rb_eStandardError);
rb_global_variable(&rb_eBrotli);
- rb_define_singleton_method(rb_mBrotli, "deflate", RUBY_METHOD_FUNC(brotli_deflate), -1);
- rb_define_singleton_method(rb_mBrotli, "inflate", RUBY_METHOD_FUNC(brotli_inflate), 1);
- rb_define_singleton_method(rb_mBrotli, "version", RUBY_METHOD_FUNC(brotli_version), 0);
+ rb_define_singleton_method(rb_mBrotli, "deflate", brotli_deflate, -1);
+ rb_define_singleton_method(rb_mBrotli, "inflate", brotli_inflate, 1);
+ rb_define_singleton_method(rb_mBrotli, "version", brotli_version, 0);
id_read = rb_intern("read");
// Brotli::Writer
id_write = rb_intern("write");
@@ -485,9 +485,9 @@ Init_brotli(void)
id_close = rb_intern("close");
rb_Writer = rb_define_class_under(rb_mBrotli, "Writer", rb_cObject);
rb_define_alloc_func(rb_Writer, rb_writer_alloc);
- rb_define_method(rb_Writer, "initialize", RUBY_METHOD_FUNC(rb_writer_initialize), -1);
- rb_define_method(rb_Writer, "write", RUBY_METHOD_FUNC(rb_writer_write), 1);
- rb_define_method(rb_Writer, "finish", RUBY_METHOD_FUNC(rb_writer_finish), 0);
- rb_define_method(rb_Writer, "flush", RUBY_METHOD_FUNC(rb_writer_flush), 0);
- rb_define_method(rb_Writer, "close", RUBY_METHOD_FUNC(rb_writer_close), 0);
+ rb_define_method(rb_Writer, "initialize", rb_writer_initialize, -1);
+ rb_define_method(rb_Writer, "write", rb_writer_write, 1);
+ rb_define_method(rb_Writer, "finish", rb_writer_finish, 0);
+ rb_define_method(rb_Writer, "flush", rb_writer_flush, 0);
+ rb_define_method(rb_Writer, "close", rb_writer_close, 0);
}
--
2.47.0
|