1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
|
From 043060b18d27f24fe723e39bc2c9e5f50dde60dd Mon Sep 17 00:00:00 2001
From: Phil Sutter <phil@nwl.cc>
Date: Fri, 22 Jun 2018 14:18:59 +0200
Subject: expr/exthdr: Fix JSON parsing on big endian
When setting NFTNL_EXPR_EXTHDR_TYPE, one needs to call
nftnl_expr_set_u8() and not nftnl_expr_set_u32(). Otherwise 'type'
variable is assigned to uint32_t parameter before being passed to
nftnl_expr_exthdr_set() as void pointer which casts it to uint8_t.
On big endian systems, the latter would only consider the most
significant byte instead of the least significant one.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
src/expr/exthdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/expr/exthdr.c b/src/expr/exthdr.c
index 75cafbc..a351835 100644
--- a/src/expr/exthdr.c
+++ b/src/expr/exthdr.c
@@ -270,7 +270,7 @@ nftnl_expr_exthdr_json_parse(struct nftnl_expr *e, json_t *root,
type = str2exthdr_type(exthdr_type);
if (type < 0)
return -1;
- nftnl_expr_set_u32(e, NFTNL_EXPR_EXTHDR_TYPE, type);
+ nftnl_expr_set_u8(e, NFTNL_EXPR_EXTHDR_TYPE, type);
}
if (nftnl_jansson_parse_val(root, "offset", NFTNL_TYPE_U32, &uval32,
--
cgit v1.2.1
|
